Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Admin option to choose French as language #1570

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

duncan222
Copy link

I have sent the signed CAA document to the email listed in the contributing guidelines.

  • Have you explained what your changes do, and why they add value?

These are changes to the admin site to add French to the list of language options. It looked as if French was added as an option on all the other sites, however the French option was missing from the Admin page. I translated the "en-US" JSON file from the admin-web-angular/src/assets/i18n directory to French and placed the contents of this translation into the "fr-FR" JSON file in the same directory.

The last changes made were to the "theme-settings.cpmponent.ts" in the admin-web-angular/src/app/components/theme-settings directory, which were adding French as an option in the drop down list that is presented in the settings side bar.

Please let me know if there is anything else I can do here. Thanks

converting to French
adding options for french in the settings side bar
@evereq evereq self-requested a review April 25, 2024 17:13
@evereq evereq changed the title Feature-admin page option to choose French as language [Feature] Admin option to choose French as language Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant