Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover states, HTML and CSS trimming #24

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

SaFrMo
Copy link
Contributor

@SaFrMo SaFrMo commented Jun 2, 2020

  • Added larger hit areas and hover states per Add hover states and larger hitboxes #23
  • Removed deprecated <center> elements
  • Trimmed CSS that duplicates browser defaults, restructured some CSS to deal with future additions more easily
  • Standardized class names

Hoverstates look like this:
hoverstates

There's a good bit of change in the CSS so I'm happy to review if there are any conflicts, but I didn't see any when merging into the existing version or my PR at #18 . Let me know anything else that looks off - thanks!

@everestpipkin everestpipkin merged commit 6342637 into everestpipkin:master Jun 2, 2020
@everestpipkin
Copy link
Owner

Looks great- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants