Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom format validators are lost when using draftV6 and using reference schemas #152

Closed
hansmire opened this issue Mar 1, 2018 · 0 comments
Closed

Custom format validators are lost when using draftV6 and using reference schemas #152

hansmire opened this issue Mar 1, 2018 · 0 comments

Comments

@hansmire
Copy link

hansmire commented Mar 1, 2018

When you have a schema that is V6 and that has a reference to a schema with custom format, the format validators are not used to validate the against referenced schema.

The problem is in initChildLoader in LoadingState. It first copies the format validators from the previous loading state. Then it overwrites all formatValidators if the spec is v6.
erosb added a commit that referenced this issue Mar 4, 2018
@erosb
fixing #152
df06811 
 * mostly taking the code from #153
 * also adding testing infrastructure for using custom format validators
 * (unrelated) properly overriding `FormatValidator#formatName()` in `RegexFormatValidator`
@erosb erosb closed this as completed Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erosb @hansmire