Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String values of format iri are not validated #231

Open
indrajra opened this issue Oct 23, 2018 · 2 comments
Open

String values of format iri are not validated #231

indrajra opened this issue Oct 23, 2018 · 2 comments

Comments

@indrajra
Copy link

It appears that IRI values are not validated, as the URI values are.

In the /json-schema/tests/src/test/resources/org/everit/json/schema/draft7/optional/iri.json, I made a copy of the test to check as below. The tests pass contrary to expectations. Creating PR with a sample shortly.
{ "description": "an invalid IRI though valid IRI reference", "data": "âππ", "valid": false }, { "description": "an invalid IRI though valid IRI reference - copy", "data": "âππ", "valid": true }

indrajra pushed a commit to indrajra/json-schema that referenced this issue Oct 23, 2018
@indrajra indrajra changed the title Format iri is not getting any validated String values of format iri are not validated Oct 23, 2018
@erosb
Copy link
Contributor

erosb commented Oct 25, 2018

Hello @indrajra ,

the iri and iri-reference formats are not supported by the library (see the format validators listing in the readme).

I'd be happy to accept a PR implementing these, but I personally won't be able to work on these in the foreseeable future.

@indrajra
Copy link
Author

@erosb - Yeah, I realised it was not there listed after posting. Thanks for letting me know the priorities. Let me first consume this lib as-is and then give a shot to enhance it for IRI support. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants