Skip to content

adding missing ConstSchema#decribePropertiesTo() method #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2018
Merged

adding missing ConstSchema#decribePropertiesTo() method #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678c1c7
adding missing ConstSchema#decribePropertiesTo() method
erosb Jan 20, 2018
cc8150e
added unittest with null permitted value to ConstSchemaTest
erosb Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/java/org/everit/json/schema/ConstSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import static org.everit.json.schema.EnumSchema.toJavaValue;

import org.everit.json.schema.internal.JSONPrinter;

public class ConstSchema extends Schema {

public static class ConstSchemaBuilder extends Schema.Builder<ConstSchema> {
Expand Down Expand Up @@ -29,6 +31,11 @@ protected ConstSchema(ConstSchemaBuilder builder) {
this.permittedValue = toJavaValue(builder.permittedValue);
}

@Override void describePropertiesTo(JSONPrinter writer) {
writer.key("const");
writer.value(this.permittedValue);
}

@Override void accept(Visitor visitor) {
visitor.visitConstSchema(this);
}
Expand Down
22 changes: 22 additions & 0 deletions core/src/test/java/org/everit/json/schema/ConstSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.everit.json.schema;

import static org.everit.json.schema.TestSupport.loadAsV6;
import static org.junit.Assert.assertEquals;

import org.json.JSONArray;
import org.json.JSONObject;
Expand Down Expand Up @@ -56,6 +57,27 @@ public void successWithObject() {
testSuccess(new JSONObject("{\"a\":\"b\", \"b\":\"a\"}"));
}

@Test
public void toStringTest() {
ConstSchema subject = ConstSchema.builder().permittedValue(true).build();
String actual = subject.toString();
assertEquals("{\"const\":true}", actual);
}

@Test
public void toStringWithNull() {
ConstSchema subject = ConstSchema.builder().permittedValue(null).build();
String actual = subject.toString();
assertEquals("{\"const\":null}", actual);
}

@Test
public void toStringWithObject() {
ConstSchema subject = ConstSchema.builder().permittedValue(new JSONObject("{\"a\":2}")).build();
String actual = subject.toString();
assertEquals("{\"const\":{\"a\":2}}", actual);
}

@Test
public void failureWithObject() {
testFailure(new JSONObject("{}"), new JSONObject("{\"a\":null}"));
Expand Down