V7 relative-json-pointer format #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgyorffi
reviewed
Jan 22, 2018
| } | ||
| for (char current = curr(); isDigit(current) && pos < input.length() - 1; current = curr()) | ||
| ; | ||
| pos--; |
There was a problem hiding this comment.
Does it work for values that consists of only positive-integer and it has more than one digits e.g. '123'? In that case I think because of the step back the other parsing (parseJsonPointer) will try to process the ending digit.
This could be prevented by something like:
if (!(pos == input.length() - 1)) { pos--; }
|
One more thing: leading zero is not allowed before digits. Could you check and test this case too? |
zgyorffi
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.