Fixing regex handling in "patternProperties"
#188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing `ObjectSchema` to represent `patternProperties` as a `Map<Regexp, Schema>` instead of `Map<Pattern, Schema>` This is a follow-up change of introducing `Regexp` and `RegexpFactory` interfaces in `1.9.0`. Keeping but deprecating existing accessor & builder methods of `ObjectSchema` which consume / return a `Pattern`, converting from/to `Regexp`. In the end, changing `ObjectSchemaLoader` to instantiate a `Regexp` instance using the configured `RegexpFactory` instead of attempting to use RE2J directly. Also bumping version number to 1.9.1, since it is going to be a quick bugfix release ASAP.
…tyTranslation()` to feed code coverage
zgyorffi
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
ObjectSchemato representpatternPropertiesas aMap<Regexp, Schema>instead ofMap<Pattern, Schema>This is a follow-up change of introducing
RegexpandRegexpFactoryinterfaces in1.9.0.Keeping but deprecating existing accessor & builder methods of
ObjectSchemawhich consume / return aPattern, converting from/toRegexp.In the end, changing
ObjectSchemaLoaderto instantiate aRegexpinstance using the configuredRegexpFactoryinstead of attempting to use RE2J directly.Also bumping version number to 1.9.1, since it is going to be a quick bugfix release ASAP.