Skip to content

Proposed fix reference that cause StackOverflowException on equals/hashCode #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Proposed fix reference that cause StackOverflowException on equals/hashCode #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8beeee4
proposed fix reference that cause StackOverflowException on equals/ha…
Dec 15, 2023
9e8add3
wip
Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/java/org/everit/json/schema/ReferenceSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ public boolean equals(Object o) {
return that.canEqual(this) &&
Objects.equals(refValue, that.refValue) &&
Objects.equals(unprocessedProperties, that.unprocessedProperties) &&
Objects.equals(referredSchema, that.referredSchema) &&
Objects.equals(title, that.title) &&
Objects.equals(description, that.description) &&
super.equals(that);
Expand All @@ -156,7 +155,7 @@ public boolean equals(Object o) {

@Override
public int hashCode() {
return Objects.hash(super.hashCode(), referredSchema, refValue, unprocessedProperties, title, description);
return Objects.hash(super.hashCode(), refValue, unprocessedProperties, title, description);
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/org/everit/json/schema/ReferenceSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void definesPropertyThrowsExc_IfNoReferredSchemaIsSet() {
public void equalsVerifier() {
EqualsVerifier.forClass(ReferenceSchema.class)
.withRedefinedSuperclass()
.withIgnoredFields("schemaLocation", "location")
.withIgnoredFields("schemaLocation", "location", "referredSchema")
//there are specifically some non final fields for loading of recursive schemas
.suppress(Warning.NONFINAL_FIELDS)
.suppress(Warning.STRICT_INHERITANCE)
Expand Down
5 changes: 5 additions & 0 deletions tests/vanilla/src/main/java/org/everit/json/schema/EmptyObjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
import org.json.JSONTokener;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class EmptyObjectTest {

@Test
Expand All @@ -23,6 +25,9 @@ public void validateEmptyObject() throws IOException {

Schema schema = SchemaLoader.load(jsonSchema);
schema.validate(jsonSubject);

assertEquals(schema, SchemaLoader.load(jsonSchema));
assertEquals(schema.hashCode(), SchemaLoader.load(jsonSchema).hashCode());
}

}