Implement variable length seconds fraction to conform with RFC-3339 #59
Conversation
|
|
||
| @Test | ||
| public void dateTimeSecFracSuccess() { | ||
| assertSuccess("2015-02-28T11:00:00.111Z", new DateTimeFormatValidator()); |
There was a problem hiding this comment.
@deepakhalale Is there any reason to remove this testcase?
There was a problem hiding this comment.
Hey @erosb, don't think I have removed the test case. I have renamed it to dateTimeWithThreeDigitsInSecFracSuccess and updated the seconds fraction from "111" to "123" to aligh with rest of the test cases that I added.
If you think the test case was there for a reason, then I will be glad to put it back.
There was a problem hiding this comment.
Ok, found it.
One final note: I've just found in the RFC3339 document that their ABNF defines fractions as:
time-fraction = ("," / ".") 1*DIGIT
I had a quick glance at the javadoc and I couldn't find any easy way to support comma too, not only dot as a separator character. Do you think there is any simple solution to fix it?
There was a problem hiding this comment.
The Json Schema Validation spec seem to suggest that the date-time format need to specifically conform to Section 5.6 of RFC-3339.
I think Section 5.6 of RFC-3339 is a specific cut down version of the ISO 8601 grammar and the ABNF date time that your referring to in the above comment, is an ISO 8601 standard.
Hope it helps.
deepakhalale
changed the title
|
All looks fine, merging. Thank you for your contribution @deepakhalale ! |
2 participants
No description provided.