Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/product-review-compatibality #539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ErdemGKSL
Copy link
Contributor

Recreate the old Basic.jsx grid header, extensions uses this

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    Fixing compatibality with review extension.
    Recreating the old grid/headers/Basic.jsx component, because it is used by product reviews extension.

What is the current behavior?

Project doesn't build when extension called "product review" is enabled on the project.
In developer mode, the admin page is blank white.

What is the new behavior?

It builds perfectly. And works everything perfectly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Recreate the old Basic.jsx grid header, extensions uses this
@ErdemGKSL ErdemGKSL changed the title Create Basic.jsx fix/product-review-compatibality May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant