Skip to content

Expose isResult helper #2

@stalniy

Description

@stalniy

Sometimes, I use SomeType | Result<Error, SomeType> as a parameter to function and I don't have a reliable way to check that value is a Result. To write code like this:

function doSomething(value: CustomType | Result<Error, CustomType>) {
  let type: SomeType;

  if (isCustomType(value)) {
     type = value;
  } else if (isResult(value)) {
     if (value.isFailure()) {
        return value;
     }
     type = value.value;
  } else {
    return Result.error(new Error(`Unexpected value ${value}`));
  }

  // some other logic
}

Or maybe something like isFailure(result) and isSuccess(result) would be more helpful, so I could write without nesting:

function doSomething(value: CustomType | Result<Error, CustomType>) {
  let type: SomeType;

  if (isCustomType(value)) {
     type = value;
  } else if (isSuccess(value)) {
     type = value.value;
  } else if (isFailure(value)) {
     return value;
  } else {
    return Result.error(new Error(`Unexpected value ${value}`));
  }

  // some other logic
}

By the way, very nice library! I enjoy using it, thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions