Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering/export broken with version > 3.0 #127

Closed
stonebanks opened this issue Feb 8, 2019 · 26 comments · Fixed by #228
Closed

Rendering/export broken with version > 3.0 #127

stonebanks opened this issue Feb 8, 2019 · 26 comments · Fixed by #228

Comments

@stonebanks
Copy link

stonebanks commented Feb 8, 2019

Hi,
I'm coming across some errors making the extension not usable since the version 3.0.0 (2.03 being the last working version )

this is a screen shot of what I have in the side panel or in the browser
image

and the following errors inside the chrome console:
image

My setup:
Version: 1.31.0 (user setup)
Commit: 7c66f58312b48ed8ca4e387ebd9ffe9605332caa
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

@evilz
Copy link
Owner

evilz commented Feb 8, 2019

Thank reporting this.
I'm on it.

@evilz
Copy link
Owner

evilz commented Feb 10, 2019

Can you try the version 3.3.1 ?
Look's like I got problem with font awesome but I don't know why :(

@stonebanks
Copy link
Author

No, I just checked and I still have the exact same errors with 3.3.1 :(

@evilz
Copy link
Owner

evilz commented Feb 11, 2019

Are you trying to put this on slideshare ?

@asalber
Copy link

asalber commented Feb 11, 2019

I have the same problem.
The presentation renders perfectly from VScode even if you open it in a browser, but it doesn't work when you export it as static html.

@evilz
Copy link
Owner

evilz commented Feb 11, 2019

@asalber My bad I forgot to mention a big breaking change. You need a web server cause now reveal js is using directly the markdown file. I mean it's an ajax request.

Use can use this chrome extension https://chrome.google.com/webstore/detail/web-server-for-chrome/ofhbbkphhbklhfoeikjpcbhemlocgigb?hl=en or any web server.

@asalber
Copy link

asalber commented Feb 12, 2019

I usually host my presentations on github and they worked perfectly until now, even using this chrome extension.
You can try this: https://github.com/asalber/manual-git
Thanks!

@evilz
Copy link
Owner

evilz commented Feb 12, 2019

Thanks for the link I take a look 😅

@distantcam
Copy link
Contributor

I just had the same problem. Switching the markdown file from CRLF to LF fixed the problem for me.

@evilz
Copy link
Owner

evilz commented Feb 13, 2019

@stonebanks, it should not be a problem by default. But since I'm now on Mac maybe I miss something.

@asalber I just publish a new version that increase timeout before stoping export can you try.
Thank

@visglz
Copy link

visglz commented Feb 13, 2019

@distantcam Thanks for the hint. I had the same problem. After the update I had to change the lineendings in the markdown files from CR/LF to LF ( I am working under Windows). @evilz Is this a behaviour of reveal.js? I wonder, because before the update it rendered correctly with CR/LF.

@stonebanks
Copy link
Author

@distantcam Thanks your workaround did the trick!

@distantcam
Copy link
Contributor

distantcam commented Feb 13, 2019

Another solution is to add these custom separator values to the yaml frontmatter.

separator: '^\r?\n---\r?\n$'
verticalSeparator: '^\r?\n--\r?\n$'

Pretty sure the fix is to change the default values in Configuration.ts.


Also, I'd just like to take the opportunity to say I love this extension. It has allowed me to make a presentation for my usergroup 100% in VSCode.

@asalber
Copy link

asalber commented Feb 13, 2019

@evilz I've tried to install the new version but I can not generate the vsix file to install it locally. I get the error:

Executing prepublish script 'npm run vscode:prepublish'...
 ERROR  Command failed: npm run vscode:prepublish
sh: 1: tsc: not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! vscode-reveal@3.3.2 vscode:prepublish: `tsc -p ./`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the vscode-reveal@3.3.2 vscode:prepublish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

I work with Linux (Kubuntu) and I have installed node version 10.15.1 and npm version 6.4.1.

The solution proposed by @distantcam does not work in my case.

@distantcam
Copy link
Contributor

@asalber Try installing Typescript and try again

npm i -g typescript

@asalber
Copy link

asalber commented Feb 14, 2019

Thanks @distantcam! Now I got the vsix for version 3.3.2, but the problem still continues 😞

@vbshift
Copy link
Contributor

vbshift commented Feb 15, 2019

@distantcam Does your regex fix the problem ?

I need to and test for this :p

@ghirardinicola
Copy link

It was very useful to have a static html in order to distribute a dynamic version of the presentation.
Do you know if there is an alternative way to have that kind of feature without asking people to install a browser plugin?

@evilz
Copy link
Owner

evilz commented Feb 21, 2019

Oki, thanks to tell me your needs 😊.
I will revert this behaviour to a real static HTML.

@ghirardinicola
Copy link

Thank you, really appreciate!

@drrui
Copy link

drrui commented Feb 28, 2019

@distantcam it really works!
but there is some problems with the font size....all the words are too small...
how to solve it ?

@distantcam
Copy link
Contributor

@drrui I don't know? I'm not the maintainer of this project. Please open another issue and provide more details like a screenshot, what system you're running, steps to reproduce. Thanks

@drrui
Copy link

drrui commented Mar 1, 2019

@distantcam Sorry, thanks a lot for your help.

@ghirardinicola
Copy link

@evilz can you point me at where to look to change the export to static html please?

@evilz
Copy link
Owner

evilz commented Apr 5, 2019

Hi, not sure to understand what you are looking for or what you want to do

@fuhrmanator
Copy link
Contributor

fuhrmanator commented Apr 29, 2019

In 3.4.0 I'm getting the same result as the OP (identical screenshot). If I start with a simple project, all the slides are combined on one page (the --- cause horizontal lines, everything is on one slide, etc.).

Edit: #127 (comment) solved the problem. Why is that not the default setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants