Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Merge pull request from GHSA-f92v-grc2-w2fg #1234

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Aug 10, 2022

  • remove delete code in DeleteAccount

  • update unit test

  • refactor test

Co-authored-by: Federico Kunze Küllmer 31522760+fedekunze@users.noreply.github.com

Closes: #XXX

Description

Push advisory fix to main


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* remove delete code in DeleteAccount

* update unit test

* refactor test

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1234 (bf32ede) into main (b1cd16e) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   52.33%   52.27%   -0.07%     
==========================================
  Files         104      104              
  Lines        9387     9383       -4     
==========================================
- Hits         4913     4905       -8     
- Misses       4225     4227       +2     
- Partials      249      251       +2     
Impacted Files Coverage Δ
x/evm/keeper/statedb.go 72.41% <100.00%> (-3.43%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants