Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

test: add integration test for the rollback cmd #1311

Merged
merged 5 commits into from
Sep 1, 2022
Merged

test: add integration test for the rollback cmd #1311

merged 5 commits into from
Sep 1, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 30, 2022 •
edited
Loading

Description

  • check the rollback cmd works in integration tests

depends: cosmos/cosmos-sdk#13089

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang
test the fixed rollback cmd
89a2caf 
- check the rollback cmd works in integration tests
@yihuang yihuang changed the title test the fixed rollback cmd test: add integration test for the fixed rollback cmd Aug 30, 2022
@yihuang yihuang changed the title test: add integration test for the fixed rollback cmd test: add integration test for the rollback cmd Aug 30, 2022
@yihuang yihuang marked this pull request as ready for review August 31, 2022 14:26
facs95
facs95 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome test.. can you please add a changelog?

@yihuang
Copy link
Contributor Author

yihuang commented Sep 1, 2022

LGTM! Awesome test.. can you please add a changelog?

Oh, I forgot to do that, thanks for the help 👍

@facs95 facs95 merged commit ca070e2 into evmos:main Sep 1, 2022
@danburck danburck mentioned this pull request Nov 30, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facs95 facs95 facs95 approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@danburck danburck Awaiting requested review from danburck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @facs95