Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(rpc): estimate gas error response #1340

Merged
merged 5 commits into from
Sep 17, 2022
Merged

Conversation

ramacarlucho
Copy link
Contributor

Closes: #XXX

Description

Fix estimate gas rpc response error when height provided is in the future.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ramacarlucho ramacarlucho requested a review from a team as a code owner September 14, 2022 09:36
@ramacarlucho ramacarlucho requested review from 0a1c and adisaran64 and removed request for a team September 14, 2022 09:36
@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1340 (e3692b2) into main (acf1547) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   54.80%   54.79%   -0.02%     
==========================================
  Files         107      107              
  Lines        9988     9990       +2     
==========================================
  Hits         5474     5474              
- Misses       4243     4245       +2     
  Partials      271      271              
Impacted Files Coverage Δ
rpc/backend/call_tx.go 0.00% <0.00%> (ø)

@fedekunze fedekunze added this to the v0.20.x milestone Sep 16, 2022
@fedekunze fedekunze changed the title Fix estimate gas rpc error fix(rpc): estimate gas error response Sep 17, 2022
@fedekunze fedekunze enabled auto-merge (squash) September 17, 2022 07:44
@fedekunze fedekunze merged commit 5c80a55 into main Sep 17, 2022
@fedekunze fedekunze deleted the rama/fix_estimate_gas_error branch September 17, 2022 07:57
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Tests issues and PR related to tests
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants