Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: index-eth-tx cmd fail on empty indexer db #1362

Merged
merged 5 commits into from
Oct 3, 2022
Merged

fix: index-eth-tx cmd fail on empty indexer db #1362

merged 5 commits into from
Oct 3, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Sep 29, 2022

Solution:

  • start from latest height is db is empty
  • improve the cmd description.

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang
fix: index-eth-tx cmd fail on empty indexer db
a14f378 
Solution:
- start from latest height is db is empty
@yihuang yihuang requested a review from a team as a code owner September 29, 2022 09:22
@yihuang yihuang requested review from hanchon and ramacarlucho and removed request for a team September 29, 2022 09:22
@yihuang
Copy link
Contributor Author

yihuang commented Sep 29, 2022

@facs95 this PR should fix the issue you mentioned before.

facs95
facs95 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 🙏

@facs95 facs95 enabled auto-merge (squash) October 2, 2022 00:15
yihuang
yihuang commented Oct 2, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 2, 2022 18:14

Head branch was pushed to by a user without write access

@yihuang
Copy link
Contributor Author

yihuang commented Oct 3, 2022

integration test passed after rerun.

@facs95 facs95 merged commit 491c3da into evmos:main Oct 3, 2022
@yihuang yihuang deleted the fix-indexer-cmd branch October 7, 2022 00:36
@danburck danburck mentioned this pull request Nov 30, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@facs95 facs95 facs95 approved these changes

@hanchon hanchon Awaiting requested review from hanchon hanchon is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yihuang @ramacarlucho @facs95