This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
imp(rpc) Add support for EVM RPC metrics #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-homsi
requested review from
hanchon and
adisaran64
and removed request for
a team
v-homsi
force-pushed
the
add_support_for_evm_rpc_metrics
branch
from
82d6126
to
e8cb111
Compare
11 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
- Coverage 55.86% 55.86% -0.01%
==========================================
Files 108 108
Lines 10015 10017 +2
==========================================
+ Hits 5595 5596 +1
- Misses 4139 4140 +1
Partials 281 281
|
v-homsi
force-pushed
the
add_support_for_evm_rpc_metrics
branch
2 times, most recently
from
5d82cad
to
8519260
Compare
- Support --metrics flag - Add EVM rpc metrics server config
v-homsi
force-pushed
the
add_support_for_evm_rpc_metrics
branch
from
8519260
to
1f2cb83
Compare
facs95
suggested changes
Oct 13, 2022
v-homsi
force-pushed
the
add_support_for_evm_rpc_metrics
branch
from
5a0021e
to
66c5829
Compare
facs95
approved these changes
Oct 14, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
This PR exposes EVM RPC metrics similar to the ones exposed by
go-ethereum.The metrics correspond to:
This PR creates a separate metrics server to serve the metrics for RPC and will be used to expose other EVM/ application metrics in the future.
Based on this discussion, three approaches are identified to exposing the metrics:
go-ethereumby passing a hardcoded flag in the CLI--metrics. This option will expose metrics that are not relevant to Ethermint and does not allow for a config file option. This is the approach chosen in this PR.The metrics exposed in this PR correspond to the EVM RPC endpoint as opposed to the tendermint one discussed here. The metrics that will be exposed include latency, number of requests, and the request type.
Sample metrics:
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)