impv(ics20): Common approval methods and tests refactor #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
requested review from
facs95 and
GAtom22
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
- Coverage 70.42% 70.39% -0.03%
==========================================
Files 313 314 +1
Lines 23310 23391 +81
==========================================
+ Hits 16416 16467 +51
- Misses 6072 6111 +39
+ Partials 822 813 -9
|
MalteHerrmann
approved these changes
Oct 12, 2023
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
|
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: add some of the refactors * add CHANGELOG * fix: common approval logic and test refactor to use the new event emitting * CHANGELOG * fix: rename variables and regenerate ABI after merge * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix: replaced name from origin to granter and minor fixes * fix: revert changes meant for another branch * fix: revert errors * fix: space --------- Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> (cherry picked from commit ee3e7da) # Conflicts: # CHANGELOG.md # precompiles/ics20/approve.go
Vvaradinov
added a commit
that referenced
this pull request
Oct 16, 2023
…) (#1873) * impv(ics20): Common approval methods and tests refactor (#1849) * fix: add some of the refactors * add CHANGELOG * fix: common approval logic and test refactor to use the new event emitting * CHANGELOG * fix: rename variables and regenerate ABI after merge * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix: replaced name from origin to granter and minor fixes * fix: revert changes meant for another branch * fix: revert errors * fix: space --------- Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> (cherry picked from commit ee3e7da) # Conflicts: # CHANGELOG.md # precompiles/ics20/approve.go * fix: merge conflicts * CHANGELOG * CHANGELOG --------- Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the 2nd PR in the series which extracts the common Approval methods into a
approve_common.go. It also fixes the failing unit and integration tests to include the correct events and names.Closes #XXX