Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes spelling of JukesCantor label #10

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Fixes spelling of JukesCantor label #10

merged 1 commit into from
Jun 2, 2017

Conversation

hlapp
Copy link
Contributor

@hlapp hlapp commented May 31, 2017

See #2. Note that this purposely leaves other files intact that contain the same mis-spelling, specifically cdao-deprecated-mappings.owl. This is because there the mis-spelling is in the term IRIs for v1.0 CDAO term IRIs. (One example why using term labels as part of term IRIs
is can be a bad idea.)

Fixes #2. Note that this purposely leaves other files intact that
contain the same mis-spelling, specifically `cdao-deprecated-mappings.owl`.
This is because there the mis-spelling is in the term IRIs for v1.0
CDAO term IRIs. (One example why using term labels as part of term IRIs
is can be a bad idea.)
@hlapp hlapp requested a review from balhoff May 31, 2017 17:05
Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to propose "Jukes–Cantor", but I think that might better be part of a comprehensive normalization of the labels in CDAO, which were automatically migrated from the old camel-case IDs.

@hlapp
Copy link
Contributor Author

hlapp commented Jun 2, 2017

Yes, I had the exact same thought.

@hlapp
Copy link
Contributor Author

hlapp commented Jun 2, 2017

Added issue #11 for this, and given @balhoff's approval am thus merging this PR as complete now.

@hlapp hlapp merged commit 49257a9 into master Jun 2, 2017
@hlapp hlapp deleted the fix-jc branch June 2, 2017 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants