forked from eXist-db/documentation
-
Notifications
You must be signed in to change notification settings - Fork 0
Suggested changes to the URL Rewriting article #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
joewiz
wants to merge
19
commits into
evolvedbinary:url-rewrite
from
joewiz:pullrequests/evolvedbinary/url-rewrite
Closed
Suggested changes to the URL Rewriting article #1
joewiz
wants to merge
19
commits into
evolvedbinary:url-rewrite
from
joewiz:pullrequests/evolvedbinary/url-rewrite
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `xref/@linkend` already correctly handles cross references using the title of the resource, but `link` can also use `@linkend` where internal links are desirable with different labels. - Refactored for best practice push XSLT paradigm.
- Built on existing work by Wolfgang and others - removed extra verbal padding for more concise document - Re-ordered some of the more complex topics to the end of the document - Re-factored headings for easier navigation from sidebar (e.g. controller XML model) and better internal linking - Reviewed the eXist O'Reilly book content to ensure documentation parity - Added some examples
- missing @xml:id on `sect2` - replace `tag` within `link` with `literal`
as suggested by @line-o
- corrected query names to `.xq` from `xql` in examples - Updated date - renumbered examples for consistency - Reworded Example 1
… most other articles in documentation use 2-space indent
3de0c86
to
a215e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamretter @yamahito Please find my suggested edits to the URL Rewriting article.