Start adding WIP dynamic SGS model from NekExamples #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinvis
commented
Sep 21, 2020
src/abl/sgs/dynsmag.f
Outdated
Comment on lines
234
to
246
| do k=1,3 | ||
| do j=1,k | ||
| sym = sym_map(j, k) | ||
|
|
||
| call col3(fi, magS, sij(:,j,k), n) ! TODO: fix imap and for our 3D sij | ||
| call tens3d1(mij(1,sym), fi, fh, fht, nx1, nx1) ! fh x fh x fh x (|S| S_ij) | ||
| call tens3d1(fi, sij(:,j,k), fh, fht, nx1, nx1) ! fh x fh x fh x S_ij | ||
| do i=1,n | ||
| if (.not. wmles_sgs_delta_max) delta_sq = dg2(i*e,1,1,1) | ||
|
|
||
| mij(i, sym) = (a2**2 * fs(i)*fi(i) - mij(i, sym))*delta_sq | ||
| enddo | ||
| enddo |
There was a problem hiding this comment.
The loop and the sym_map has been modified compared to the original code here:
There was a problem hiding this comment.
Reason: sij has a different array shape in the NekExamples version
src/abl/sgs/dynsmag.f
Outdated
Comment on lines
52
to
57
| do i=1,ntot | ||
| ur(i) = mij(i,1)*lij(i,1)+mij(i,2)*lij(i,2)+mij(i,3)*lij(i,3) | ||
| $ + 2*(mij(i,4)*lij(i,4)+mij(i,5)*lij(i,5)+mij(i,6)*lij(i,6)) | ||
| us(i) = mij(i,1)*mij(i,1)+mij(i,2)*mij(i,2)+mij(i,3)*mij(i,3) | ||
| $ + 2*(mij(i,4)*mij(i,4)+mij(i,5)*mij(i,5)+mij(i,6)*mij(i,6)) | ||
| enddo |
src/abl/sgs/dynsmag.f
Outdated
Comment on lines
47
to
48
| call comp_mij(ur,us,nt,e) | ||
| call comp_lij(vx,vy,vz,ur,us,ut,e) |
There was a problem hiding this comment.
Moved some arguments to the include file DYN since it is in a common block.
ashwinvis
commented
Sep 22, 2020
src/abl/sgs/dynsmag.f
Outdated
Comment on lines
227
to
230
| c a2 is the test- to grid-filter ratio, squared | ||
|
|
||
| a2 = nx1-1 ! nx1-1 is number of spaces in grid | ||
| a2 = a2 /(nt-1) ! nt-1 is number of spaces in filtered grid |
There was a problem hiding this comment.
Is this correct? nt=-9 and is hard coded
ashwinvis
force-pushed
the
enh/dynsmag
branch
3 times, most recently
from
e94c45d
to
be218dc
Compare
Also move common subroutines to sgs/utils.f See: Nek5000/NekExamples@1a5387c#diff-c8af13c2833a71991ab55ac28bec8d13
planar_average_r and wall_normal_average_s
ashwinvis
force-pushed
the
enh/dynsmag
branch
from
be218dc
to
8b3c996
Compare
ashwinvis
commented
Oct 8, 2020
ashwinvis
commented
Oct 8, 2020
Closed
Uses Nek v19 API for averaging
Cosmetic: ctags verbose log
Remove unused variables in dynamic model
First average in z then x as pointed in the example of planar_avg. Comment out planar_avg_horiz and try planar_avg_spanwise for now.
The subroutine seems to work well. Except for some periodicity near the wall when plotting num and den output of the dyn_smag SGS model.
c.f.: Gadde, Stieren, and Stevens, “Large-Eddy Simulations of Stratified Atmospheric Boundary Layers.”
Write to spatial_means.txt
ashwinvis
force-pushed
the
enh/dynsmag
branch
from
269a854
to
05b6ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.