New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup and improvements #79

Closed

snehlsen opened this issue Feb 12, 2019 · 0 comments

Contributor

snehlsen commented Feb 12, 2019

In #75 some suggestions from the review were left for an extra refactoring branch.
Open review issues are:

Fix naming convert Jdbc to JDBC
Extract constants for JSON properties
Use Optional instead of returning null
Make string operations locale sensitive
Use parameter objects
Remove assert
Remove commented code
Use Hamcrest matchers in tests

snehlsen added the enhancement label

AnastasiiaSergienko closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment