Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#151: enabled join pushdown for postgresql #173

Merged
merged 7 commits into from
May 7, 2019
Merged

#151: enabled join pushdown for postgresql #173

merged 7 commits into from
May 7, 2019

Conversation

snehlsen
Copy link
Contributor

@snehlsen snehlsen commented May 6, 2019

Join pushdown for postgresql (#151)

@snehlsen snehlsen requested a review from redcatbear May 7, 2019 05:03
redcatbear
redcatbear requested changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with small findings.

...dbc-adapter/src/test/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialectIT.java Outdated Show resolved Hide resolved
...dbc-adapter/src/test/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialectIT.java Outdated Show resolved Hide resolved
...dbc-adapter/src/test/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialectIT.java Outdated Show resolved Hide resolved
...dbc-adapter/src/test/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialectIT.java Outdated Show resolved Hide resolved
redcatbear
redcatbear approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one more finding.

...dbc-adapter/src/test/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialectIT.java Outdated Show resolved Hide resolved
@redcatbear redcatbear merged commit ce5c10a into master May 7, 2019
@redcatbear redcatbear deleted the feature/151_enable_join_pushdown_for_postgresql branch May 7, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snehlsen @redcatbear