Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaultRowHeight not working #855

merged 2 commits into from Jun 13, 2019


Copy link

commented Jun 11, 2019

@@ -13,6 +13,7 @@ class SheetFormatPropertiesXform extends BaseXform {
outlineLevelRow: model.outlineLevelRow,
outlineLevelCol: model.outlineLevelCol,
'x14ac:dyDescent': model.dyDescent,
customHeight: model.defaultRowHeight === 0 ? '0' : '1',

This comment has been minimized.

Copy link

guyonroche Jun 11, 2019


Could you fix the unit tests that have failed due to this change

This comment has been minimized.

Copy link

autukill Jun 11, 2019

Author Contributor


@guyonroche guyonroche merged commit 839c7f5 into exceljs:master Jun 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@autukill autukill deleted the autukill:master branch Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.