Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ UPGRADE: Allow linkify-it-py v2 #218

merged 2 commits into from Feb 22, 2023


Copy link

@hukkin hukkin commented May 9, 2022

A port of linkify-it 4.0.0 (changelog here) which makes a couple fixes and adds a new method

Copy link

codecov bot commented May 9, 2022

Codecov Report

No coverage uploaded for pull request base (master@032c742). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #218   +/-   ##
  Coverage          ?   96.08%           
  Files             ?       62           
  Lines             ?     3221           
  Branches          ?        0           
  Hits              ?     3095           
  Misses            ?      126           
  Partials          ?        0           
Flag Coverage Δ
pytests 96.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

Heya, could you briefly outline what the changes in v2 are and how it might affect parsing?

Copy link
Member Author

hukkin commented May 9, 2022

It seems to be a port of linkify-it 4.0.0 (changelog here) which makes a couple fixes and adds a new method. Doesn't seem like a breaking change despite the major version bump. Also all tests pass so 🤷 seems good to me.

@chrisjsewell chrisjsewell merged commit 4670f0c into executablebooks:master Feb 22, 2023
14 checks passed
Copy link

better late than never 😅

@hukkin hukkin deleted the allow-linkify-v2 branch February 27, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants