Skip to content

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Sep 21, 2020

Switch to a more minimal icon from Tabler icons!

100% up for discussion, but I reckon this will look nicer for us. It should also some #69 since the icon includes a height and width as well.

Switch to a more minimal icon from Tabler icons!
@welcome
Copy link

welcome bot commented Sep 21, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

I think this works for me - I haven't seen that icon in docs before but if it is relatively standard then a more minimal icon sounds good (also smaller in KB too). Any particular reason you don't like the current icons?

@pradyunsg
Copy link
Member Author

pradyunsg commented Sep 21, 2020

There's too much happening and it looks (IMO) not as nice as mkdocs-material's version of this. :)

@choldgraf
Copy link
Member

Sounds good, I guess I am 50/50 on it so your vote can tip the PR in favor of merging haha.

as a general rule I think we wanna avoid rabbit holes of "differences in design opinion" because we'll spend hours going around in circles...

@choldgraf choldgraf changed the title Update copy-button.svg ✨ IMPROVE: Update copy-button.svg Sep 21, 2020
@choldgraf choldgraf merged commit 852a946 into executablebooks:master Sep 21, 2020
@welcome
Copy link

welcome bot commented Sep 21, 2020

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@pradyunsg pradyunsg deleted the patch-1 branch September 21, 2020 17:45
@pradyunsg
Copy link
Member Author

Any way to make a release with this? :puppy-face:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants