Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sending large eBPF events more memory efficient #73

Closed
MatteoNardi opened this issue Oct 10, 2022 · 1 comment · Fixed by #119
Closed

Make sending large eBPF events more memory efficient #73

MatteoNardi opened this issue Oct 10, 2022 · 1 comment · Fixed by #119
Assignees
@MatteoNardi
Labels
enhancement New feature or request

Comments

@MatteoNardi
Copy link
Contributor

MatteoNardi commented Oct 10, 2022 •
edited
Loading

When sending events from eBPF programs to userspace, we always allocate the max length of bytes the given field supports. For example, in file-system-monitor, we send filenames of NAME_MAX length (1024) even when it's much shorter. Moreover, this leads us to being excessively conservative with the maximum field lengths.

We should design a data structure/protocol which allows to send only the data actually needed.
@MatteoNardi MatteoNardi added the enhancement New feature or request label Oct 10, 2022
@MatteoNardi MatteoNardi mentioned this issue Oct 10, 2022
Merged
4 tasks
@MatteoNardi
Copy link
Contributor Author

Once this if fixed, we increase the following constants:

  • file-system-monitor. The maximum file paths should be 4096
  • process-monitor. The maximum path of binaries should be 4096
  • process-monitor. Ideally, the maximum arguments size should be 2097152

MatteoNardi added a commit that referenced this issue Oct 11, 2022
@MatteoNardi
misc(process-monitor): improve warning message
73fabdf 
This also makes sure so send as much data as possibile when the argument
list is too long.

Ref #73
@MatteoNardi MatteoNardi mentioned this issue Oct 11, 2022
Merged
MatteoNardi added a commit that referenced this issue Oct 11, 2022
@MatteoNardi
misc(process-monitor): improve warning message
bd40931 
This also makes sure so send as much data as possibile when the argument
list is too long.

Ref #73
@MatteoNardi MatteoNardi self-assigned this Nov 30, 2022
@MatteoNardi MatteoNardi linked a pull request Dec 2, 2022 that will close this issue
Make sending large eBPF events more memory efficient #119
Merged
4 tasks
@MatteoNardi MatteoNardi mentioned this issue Dec 2, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatteoNardi MatteoNardi

Labels
enhancement New feature or request
Projects
Pulsar
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sending large eBPF events more memory efficient exein-io/pulsar
1 participant
@MatteoNardi