-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validatron rewrite: rules engine improvements #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule engine, collection support, dynamic fields compare support
MatteoNardi
reviewed
May 19, 2023
MatteoNardi
approved these changes
May 19, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validatron rewrite: rules engine improvements
This pr is a complete rewrite of
validatron
crate with all derived changes.CONTAINS
) as mentioned in rule engine dsl syntax changes #71, so closes dsl collection support #112 where there is the previous attemptImplementation (Optional)
validatron
with a single trait instead of previously multiple traits (for struct and for enum)validatron
to the rules engine, as it's specifically designed to work with our rulesI have
cargo fmt
;cargo clippy
;cargo test
and all tests pass;