Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Add key features and tags #329

Merged
merged 2 commits into from
Jun 9, 2021
Merged

[v3] Add key features and tags #329

merged 2 commits into from
Jun 9, 2021

Conversation

bobbicodes
Copy link
Member

@bobbicodes bobbicodes commented Feb 6, 2021

Issues: #316 and #317.

@bobbicodes bobbicodes requested a review from a team February 6, 2021 19:25
@bobbicodes bobbicodes changed the title add key features add key features and tags Feb 6, 2021
@bobbicodes bobbicodes changed the title add key features and tags [v3] Add key features and tags Feb 6, 2021
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it looks like nobody else is reviewing, LGTM!

@bobbicodes bobbicodes merged commit 9f8cd76 into main Jun 9, 2021
@bobbicodes bobbicodes deleted the key-features branch June 9, 2021 13:05
@ErikSchierboom
Copy link
Member

@porkostomus There are a couple of issues with the tags and key features according to configlet (must have been a very old version that checked the PR :)):

The value of `key_features.content` that starts with `Clojure extends Lisp's co`... is 139 characters, but it must not exceed 100 characters:
/home/erik/exercism/clojure/config.json

The value of `key_features.content` that starts with `Clojure's primary program`... is 140 characters, but it must not exceed 100 characters:
/home/erik/exercism/clojure/config.json

The value of `key_features.content` that starts with `Clojure provides the tool`... is 166 characters, but it must not exceed 100 characters:
/home/erik/exercism/clojure/config.json

The value of `key_features.content` that starts with `Clojure is impure, in tha`... is 133 characters, but it must not exceed 100 characters:
/home/erik/exercism/clojure/config.json

The value of `key_features.content` that starts with `Clojure, being a practica`... is 224 characters, but it must not exceed 100 characters:
/home/erik/exercism/clojure/config.json

The value of `key_features.content` that starts with `Clojure is designed to be`... is 234 characters, but it must not exceed 100 characters:
/home/erik/exercism/clojure/config.json

The `tags` array contains `used_for/used_for/frontends`, which is not one of the allowed values:
/home/erik/exercism/clojure/config.json

But those can be fixed in a follow-up PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants