Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse string approaches #609

Merged
merged 12 commits into from
Jan 23, 2024

Conversation

michalporeba
Copy link
Contributor

Resolves #601

It's an early draft for early feedback.

@michalporeba michalporeba marked this pull request as ready for review January 21, 2024 19:31
@michalporeba
Copy link
Contributor Author

The approaches are ready for review. @iHiD, @ErikSchierboom

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalporeba Left a quick review.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content! Some tiny nits.

exercises/practice/reverse-string/.approaches/config.json Outdated Show resolved Hide resolved
exercises/practice/reverse-string/.approaches/config.json Outdated Show resolved Hide resolved
exercises/practice/reverse-string/.approaches/config.json Outdated Show resolved Hide resolved
exercises/practice/reverse-string/.approaches/config.json Outdated Show resolved Hide resolved
michalporeba and others added 4 commits January 22, 2024 13:18
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@michalporeba
Copy link
Contributor Author

@ErikSchierboom, @tasxatzial, thanks for the feedback. I have made changes to the text. What do you think about it now?

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more typo

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you removed the letfn example. I hope you don't mind two final suggestions.

michalporeba and others added 2 commits January 22, 2024 19:34
…t.md

Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
…t.md

Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
@michalporeba
Copy link
Contributor Author

@ErikSchierboom thanks for approving the PR. I think you will have to click the merge button, as the track's maintainer is currently unavailable. The leap approaches were merged by @iHiD

@ErikSchierboom ErikSchierboom merged commit 305af6e into exercism:main Jan 23, 2024
2 checks passed
@iHiD
Copy link
Member

iHiD commented Jan 23, 2024

Great work. Thank you! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse-string 48in24 approaches
4 participants