-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse string approaches #609
Reverse string approaches #609
Conversation
The approaches are ready for review. @iHiD, @ErikSchierboom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalporeba Left a quick review.
exercises/practice/reverse-string/.approaches/its-a-sequence/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.approaches/recursion/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.approaches/its-a-sequence/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.approaches/recursion/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.approaches/its-a-sequence/content.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content! Some tiny nits.
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@ErikSchierboom, @tasxatzial, thanks for the feedback. I have made changes to the text. What do you think about it now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you removed the letfn
example. I hope you don't mind two final suggestions.
exercises/practice/reverse-string/.approaches/recursion/content.md
Outdated
Show resolved
Hide resolved
exercises/practice/reverse-string/.approaches/recursion/content.md
Outdated
Show resolved
Hide resolved
…t.md Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
…t.md Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
@ErikSchierboom thanks for approving the PR. I think you will have to click the merge button, as the track's maintainer is currently unavailable. The leap approaches were merged by @iHiD |
Great work. Thank you! 💙 |
Resolves #601
It's an early draft for early feedback.