build: cross compilation script duplicates some logic #789
Labels
kind: build
Non-.nim changes that affect the release binary
Comments
3 tasks
ee7
added a commit
that referenced
this issue
Aug 16, 2023
Before this commit, the publish-release script handled both:
- creating the draft release
- uploading assets to the release
with the intention that the first build job to finish would create the
release with one asset, and each later job would upload an asset.
The logic was like:
if ! gh release view "${build_tag}"; then
gh release create [...]
else
gh release upload [...]
fi
But this had a race. For example, if two build jobs finished at nearly
the same moment, they could each create a draft release. This race was
almost never encountered in practice, and was easily resolved by
deleting a draft release and restarting a build job, but it's worth
resolving.
Add an initial build job to create a draft release that has no assets,
and make the later build jobs only upload to that release.
This fixes the race, and makes it easier to share logic between the
native build jobs and the cross-compiling build jobs.
Fixes: #551
Refs: #789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-up from #460 (comment)
The text was updated successfully, but these errors were encountered: