ci: only run tests when source changes #162
Conversation
.github/workflows/tests.yml
Outdated
| on: | ||
| push: | ||
| paths: | ||
| - "**.nim" |
There was a problem hiding this comment.
See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths for examples of what this pattern does
There was a problem hiding this comment.
"**.cfg" could be another candidate for inclusion too, but we don't have one - it's fine.
I have some reservations that this could become outdated easily: I can imagine myself adding a new file, or moving some around, and not noticing that the test check is skipped (especially if there are many PRs, or more jobs/workflows in the future).
Maybe it would be safer to have the reverse filter? That is, an explicit list of files to skip.
I think the list of files that tests.yml effectively ignores with this PR is:
.github/CODEOWNERS
.github/dependabot.yml
.gitignore
LICENSE
README.md
configlet.version
scripts/fetch-configlet
scripts/fetch-configlet.ps1
That list is a bit longer than the list in the PR currently, and it might grow more quickly. But the failure mode seems better: a build when you didn't want one, rather than a PR passing when it should be failing.
What do you think?
To prevent the tests workflow from running unnecessarily we don't run it when Markdown files are changed
|
Yeah, there is a trade-off. Let's just simplify things and not run the tests when just Markdown files have changed. I have to look into how to encode that in the workflow. |
|
I'm closing this in favor of #170 due to me having deleted my fork, which I apparently submitted the PR from. |
To prevent the tests workflow from running unnecessarily (which is quite slow due to the slowness of the mac build), we'll only run it when either:
I've verified this on my fork: https://github.com/ErikSchierboom/canonical-data-syncer/actions
Closes #141