Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.example files #16

Closed
tgecho opened this issue Mar 12, 2016 · 4 comments
Closed

*.example files #16

tgecho opened this issue Mar 12, 2016 · 4 comments

Comments

@tgecho
Copy link
Contributor

tgecho commented Mar 12, 2016

Since things are still in an early state, does anyone have any objections to switching to ExerciseExample.elm as the example naming convention? I'm working on adding a few exercises and it's a bit tedious since editors don't really like the .example extension. Also, it would make it possible to dev on a test by simply changing the import line to import BobExample exposing (hey).

Any thoughts/objections? @parkerl @kytrinyx

@parkerl
Copy link
Contributor

parkerl commented Mar 12, 2016

Hey @tgecho, welcome to the party! I'm personally open to anything. Using .example was an easy way to get CI working and keeps the build script nice and simple.

FWIW, my process has been to develop as normal with the regular .elm extension, like HelloWorld.elm. I don't use the build script for testing when working on an exercise but call elm-test directly with elm-test exercises/hello_world/HelloWorldTests.elm. When the exercise is green, the final steps are to change the extension, add the template file and run bin/build.sh.

That has been working well for me.

@tgecho
Copy link
Contributor Author

tgecho commented Mar 12, 2016

Yep... after doing a few more exercises (PRs incoming!) I care even less strongly about this. The only concrete reason I can come up with is if someone comes along and wants to view an example the syntax highlighting will be off.

On the other hand, technically a BobExample.elm file with module Hamming (..) where is invalid... so yeah, I don't care enough :)

@tgecho tgecho closed this as completed Mar 12, 2016
@parkerl
Copy link
Contributor

parkerl commented Mar 12, 2016

Ooooo PRs! Sweet! I'm glad things are working for you. 🎉

@parkerl
Copy link
Contributor

parkerl commented Mar 12, 2016

@tgecho I am going to update the README a bit with this workflow. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants