Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run elm-format on CI #47

Closed
parkerl opened this issue Mar 20, 2016 · 4 comments
Closed

Run elm-format on CI #47

parkerl opened this issue Mar 20, 2016 · 4 comments
Assignees

Comments

@parkerl
Copy link
Contributor

parkerl commented Mar 20, 2016

Because we are being strict about formatting we should fail the build if elm-format causes diffs.

@parkerl parkerl self-assigned this Mar 20, 2016
@justgage
Copy link

I would be a little afraid that this would cause people to become a little discouraged. I think suggesting to use it with a bot in a comment after they submit it could be a good thing.

@kytrinyx
Copy link
Member

@justgage To clarify this about pull requests on GitHub to the Exercism Elm track, not about failing the tests when people are submitting exercises to the website.

@justgage
Copy link

Ah yes, that's a good idea. Sorry about that.

@kytrinyx
Copy link
Member

No apologies necessary—you've got everyone's best interest in mind (and I agree with you: this would be frustrating and potentially quite discouraging if we did it on the website).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants