Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type mentioned in the description of step 4 of the learning exercise Secure Treasure Chest #593

Closed
rjpgt opened this issue Sep 4, 2023 · 1 comment · Fixed by #594
Closed

Wrong type mentioned in the description of step 4 of the learning exercise Secure Treasure Chest #593

rjpgt opened this issue Sep 4, 2023 · 1 comment · Fixed by #594

Comments

@rjpgt
Copy link

rjpgt commented Sep 4, 2023

Step 4 of the exercise description:

This function should take two parameters, and have a type definition.

a String (for the password)
a TreasureChest generic custom type

Shouldn't TreasureChest be SecureTreasureChest ?
ceddlyburge added a commit that referenced this issue Sep 5, 2023
@ceddlyburge
Update instructions.md
2d48ff6 
Fixes #593
@ceddlyburge ceddlyburge mentioned this issue Sep 5, 2023
Merged
@ceddlyburge
Copy link
Contributor

Good spot jagapoga! I've created a pull request which you can review if you would like.
#594

You are welcome to create pull requests yourself by the way.

Cheers, Cedd

ceddlyburge added a commit that referenced this issue Sep 6, 2023
@ceddlyburge
Update instructions.md (#594)
9a7357b 
Fixes #593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update instructions.md exercism/elm
2 participants
@ceddlyburge @rjpgt