Copy changes. Fixes #492 #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaro121
reviewed
Jun 18, 2022
Comment on lines
11
to
13
| Define the remainingTimeInMinutes function that takes two parameters and has a let expression as its body. The first parameter is the number of layers in the lasagna, and the second parameter is the number of minutes since you starting cooking. | ||
|
|
||
| Define expectedMinutesInOven (in the `let` part of the `let` expression) to check how many minutes the lasagna should be in the oven. According to the cooking book, the expected oven time in minutes is 40: |
There was a problem hiding this comment.
Both remainingTimeInMinutes and expectedMinutesInOven are missing backticks.
exercises/concept/luigis-luscious-lasagna/.docs/instructions.md
Outdated
Show resolved
Hide resolved
|
|
||
| ```elm | ||
| preparationTimeInMinutes 3 | ||
| --> 6 | ||
| ``` | ||
|
|
||
| Define the `remainingTimeInMinutes` function (in the `in` part of the `let` expression) that takes two parameters: the first parameter is the number of layers you added to the lasagna, and the second parameter is the number of minutes since you starting cooking. The function should return how many minutes are left until the lasagna is finished, which is the sum of the `preparationTimeInMinutes` and the `expectedMinutesInOven` minus the number of minutes since you starting cooking. | ||
| Return how many minutes are left until the lasagna is finished (in the `in` part of the `let` expression), which is the sum of the preparationTimeInMinutes and the expectedMinutesInOven minus the number of minutes since you starting cooking. |
There was a problem hiding this comment.
preparationTimeInMinutes and expectedMinutesInOven missing backticks.
exercises/concept/lucians-luscious-lasagna/.docs/instructions.md
Outdated
Show resolved
Hide resolved
alvaro121
reviewed
Jun 19, 2022
| @@ -60,7 +60,7 @@ stillAlice = Dict.remove 1 --> ( 0, "Alice" ) | |||
| empty = Dict.remove 0 alice --> Dict.empty | |||
| ``` | |||
|
|
|||
| A list of key value pairs can be converted into a dict with `fromList`. | |||
| A list of key value pairs can be converted into a dict with `fromList`. | |||
There was a problem hiding this comment.
Ok, I've fixed that.
|
@mpizenberg @jiegillet could you take a look at this PR? |
|
Hey, I can take a look tomorrow |
mpizenberg
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.