Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that penceToPounds is Int -> Float #592

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Test that penceToPounds is Int -> Float #592

merged 1 commit into from
Aug 30, 2023

Conversation

ceddlyburge
Copy link
Contributor

@ceddlyburge ceddlyburge mentioned this pull request Aug 30, 2023
Closed
mpizenberg
mpizenberg approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@mpizenberg mpizenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick to force penceToPounds to take an Int.

softmoth
softmoth approved these changes Aug 30, 2023
View reviewed changes
Copy link

@softmoth softmoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ceddlyburge ceddlyburge merged commit db13ecb into main Aug 30, 2023
5 checks passed
@ceddlyburge ceddlyburge deleted the bettys-bike-shop-tests branch August 30, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softmoth softmoth softmoth approved these changes

@mpizenberg mpizenberg mpizenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bettys-bike-shop tests do not actually verify type signature
3 participants
@ceddlyburge @softmoth @mpizenberg