Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename exercise files to match exercise name #67

Closed
6 tasks done
kytrinyx opened this issue Aug 14, 2017 · 2 comments
Closed
6 tasks done

Rename exercise files to match exercise name #67

kytrinyx opened this issue Aug 14, 2017 · 2 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Aug 14, 2017

We have a number of exercises that have names that do not match the exercise name.

E.g. the exercise word-count has the file names Phrase.groovy and PhraseSpec.groovy. This means that we cannot generate the correct command to run automatically.

In order to make it possible to generate this, the filenames should be based on the exercise name. So word-count should have the filenames WordCount.groovy and WordCountSpec.groovy.

It would also make sense to update the class names in the exercises to match the filenames.

These are the exercises in question.

  • difference-of-squares
  • nth-prime
  • rna-transcription
  • robot-name
  • roman-numerals
  • word-count

#64 should probably be merged before this issue gets addressed, since it adds more files that need to be renamed to address this issue.

@ilya-khadykin
Copy link
Contributor

Thanks for creating the issue!
I'll fix it later today

@ilya-khadykin
Copy link
Contributor

I've also checked other exercises and found some inconsistency in leap and corrected it as well.

PR #69 has been created.
@kytrinyx, please take a look when you have a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants