feat: a new simple (correct) test that may break some accepted solutions #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the community solutions incorrectly try to locate STOP codons from input and strip anything that follows the first STOP codon. This is a neat idea, but if the regex is not anchored, or if it does not align to groups of 3 - it's possible that a valid pair of codons (
AUGAUG
, for example,) creates a pattern that can cause the regex mis-identify a sequence as a STOP codon when it is not (UGA
, in the previous example).Summary
A couple of the accepted solutions to this problem have a subtle bug that the tests are not catching. This PR corrects that by putting a simple test in place.
Click to see examples...
Bonus
I noticed that the contractions in the test descriptions were not rendering correctly, so I changed them to non-contractions.
Checklist
./bin/configlet generate
to ensure all documents are properly generated.