Add ISBN Verifier Exercise #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
mk-mxp
added
x:action/create
mk-mxp
approved these changes
Feb 26, 2024
|
@ErikSchierboom Do you have an idea, what really went wrong with the CI tests on MacOS? It looks like there is a library missing on the MacOS image. But that was not the case some hours ago. The image tag hasn't changed and the workflow is all the same. Any clues? |
|
I don't, but what you could do is to pin to a specific version of the Mac runner in .github/workflows/exercise-tests-phpunit-9.yml. It's currently using latest which can cause these sudden breakages |
|
@tomasnorre Please rebase to disable MacOS testing. This fails for reasons out of our control. |
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
tomasnorre
force-pushed
the
add-isbn-verifier-exercise
branch
from
19d3743
to
b4e72a8
Compare
|
Thanks for your patience with CI and me 😄 |
No worry, we all want to do it as good as possible. Really appreciate your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just picked one by "random".