Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate binary, trinary, octal, and hexadecimal in favor of new all-your-base exercise #279

Open
6 of 10 tasks
kytrinyx opened this issue Jun 23, 2016 · 20 comments
Open
6 of 10 tasks

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Jun 23, 2016

We've settled on replacing the four almost identical exercises with one that is more interesting and comprehensive, which converts a number in an arbitrary base to the equivalent in a second arbitrary base. See #276 for details.

We need to (I think):

  • wait for the pull request that adds all-your-base to be accepted
  • finish working out the process for deprecating exercises in Formalize the process for deprecating exercises discussions#40
  • add a .deprecated file to octal
  • add a .deprecated file to hexadecimal
  • add a .deprecated file to binary
  • add a .deprecated file to trinary
  • draft the text for a new issue that can be submitted to all the languages (see https://github.com/exercism/blazon#tips)
  • submit the issue using blazon
  • wait for all the related issues to be closed
  • close this issue
@kytrinyx
Copy link
Member Author

FYI @rbasso @NobbZ @ErikSchierboom @wobh @Cohen-Carlisle @yurrriq

Before we can submit a blazon ticket we need to finish clarifying the process for deprecating exercises. Up until now it's been messy and prone to error, and I'd rather have that all straightened out before we deprecate four at a time across a bunch of language tracks. exercism/discussions#40

I've updated the checklist in the original post of this issue to reflect what I think we need to do to get this all sorted out.

@kytrinyx
Copy link
Member Author

We are missing the .deprecated file in these exercises. I've updated the checklist to reflect that we need to do this.

tree -a exercises/{binary,trinary,octal,hexadecimal}
exercises/binary
├── canonical-data.json
├── description.md
└── metadata.yml
exercises/trinary
├── canonical-data.json
├── description.md
└── metadata.yml
exercises/octal
├── description.md
└── metadata.yml
exercises/hexadecimal
├── description.md
└── metadata.yml

kotp added a commit that referenced this issue Feb 14, 2017
kotp added a commit that referenced this issue Feb 14, 2017
kotp added a commit that referenced this issue Feb 14, 2017
behrtam added a commit to exercism/python that referenced this issue Feb 14, 2017
The exercises binary, trinary, octal and hexadecimal were replaced 
in favor of all-your-base, see exercism/problem-specifications#279
snahor added a commit to snahor/xsml that referenced this issue Jun 27, 2017
emcoding pushed a commit that referenced this issue Nov 19, 2018
* generate pangram exercise
@bitfield
Copy link
Contributor

bitfield commented Jan 4, 2019

Are we ready to go ahead and Blazon this now, @kytrinyx?

@kytrinyx
Copy link
Member Author

kytrinyx commented Jan 6, 2019

Yeah, I think that's a good call. I would probably write a custom script that actually makes the PR to each track, to be honest. That's almost as easy as opening an issue, and it makes it much easier for maintainers to just accept it.

@bitfield
Copy link
Contributor

bitfield commented Jan 6, 2019

That sounds marvellous! Happy to help with that if I can (maybe there should be an issue saying that we need this tool, and other people might be able to help with it too).

@ErikSchierboom
Copy link
Member

I wrote a script to check whether any tracks still implement the binary/trinary/octal/hexadecimal exercises, and this is the list:

Track Exercise
babashka binary
babashka hexadecimal
babashka trinary
babashka octal
c binary
clojure binary
clojure hexadecimal
clojure trinary
clojure octal
coffeescript binary
coffeescript hexadecimal
coffeescript trinary
cpp trinary
cpp binary
cpp hexadecimal
crystal binary
emacs-lisp binary
emacs-lisp trinary
julia trinary
lfe binary
lfe trinary
lua binary
lua octal
mips binary
mips hexadecimal
mips octal
mips trinary
pharo-smalltalk binary
php binary
php trinary
plsql binary
prolog binary
scheme octal
scheme trinary
vbnet binary
wren binary

Apparently, there are still quite some tracks that implement these exercises. Do we want to make an effort of deprecating these?

@junedev
Copy link
Member

junedev commented Jan 13, 2022

I would be in favor of giving maintainers another nudge here to deprecate (and inform them about the replacement exercise). The old repetitive exercises were quite annoying as a student back then.

Also I am wondering why a new track like wren decided to implement a deprecated exercise. 🤔 @joshgoebel can clarify this maybe.

@wolf99
Copy link
Contributor

wolf99 commented Jan 13, 2022

As a maintainer, I would be in favour of getting such a nudge, preferably (though not necessarily) as a PR, as it would be a good candidate for a good-first-pr.

@junedev
Copy link
Member

junedev commented Jan 13, 2022

Sidenote: In case we decide to notify maintainers and define how, this could also be applied for #1918 in case this gets merged.

@BethanyG
Copy link
Member

I'd definitely appreciate a reminder or nudge or PR. 😄 I think Python has successfully "killed" all the number-base related exercises, and we have the all your base exercise....but without a reminder, I'll never check to make sure.

@ErikSchierboom
Copy link
Member

I'm wondering if a PR might be a little too "in your face." Not all tracks have implemented the more general all-your-base exercise I think. Maybe open an issue on all tracks instead?

@junedev
Copy link
Member

junedev commented Jan 14, 2022

I think @wolf99 actually meant "issue" as they wrote they want to label it "good first [issue]". I also think an issue would be good, preferably including a link to the "how to deprecate docs" and a mention of the new exercise.

fapdash added a commit to fapdash/exercism--emacs-lisp that referenced this issue Dec 4, 2022
fapdash added a commit to exercism/emacs-lisp that referenced this issue Dec 17, 2022
See exercism/problem-specifications#279

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests