Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary: improve tests for invalid numbers #96

Closed
kytrinyx opened this issue Apr 7, 2016 · 3 comments
Closed

binary: improve tests for invalid numbers #96

kytrinyx opened this issue Apr 7, 2016 · 3 comments

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 7, 2016

We should have separate tests for:

  • alphabetic characters at the beginning of a valid binary number
  • alphabetic characters at the end of a valid binary number
  • alphabetic characters in the middle of an otherwise valid binary number
  • invalid digits (e.g. 2)

If the test suite for binary has test cases that cover these edge cases, this issue can safely be closed.

See exercism/problem-specifications#95

@NobbZ
Copy link
Member

NobbZ commented Apr 7, 2016

I'd prefer to have a JSON with testdata before fixing this. Fixing without might introduce additional noise when there appears common testdata.

@NobbZ
Copy link
Member

NobbZ commented Jul 7, 2016

Since we are in the process of deprecating binary along other exercises in a big sweep (exercism/problem-specifications#279), I think we can close this, can't we?

@kytrinyx
Copy link
Member Author

agreed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants