Add skeleton files for exercises #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheanex
force-pushed
the
add-skeleton-files
branch
from
c593556
to
52e7c5b
Compare
behrtam
reviewed
Mar 8, 2017
exercises/linked-list/linked_list.py
Outdated
|
|
||
|
|
||
| class LinkedList(object): | ||
| class LinkedList: |
There was a problem hiding this comment.
As we support Python 2 & 3 we should subclass from object to have new style classes in both versions. That goes for all other cases as well. Apart from that this is good to go.
|
You could also use one of the available keywords (https://help.github.com/articles/closing-issues-via-commit-messages/) in your commit message to auto close issue #272 when this gets merged. |
pheanex
force-pushed
the
add-skeleton-files
branch
2 times, most recently
from
1fc217c
to
3e87228
Compare
|
Ah thank you for the keyword tip. I forgot about that one :-) |
pheanex
force-pushed
the
add-skeleton-files
branch
from
3e87228
to
d38bbc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.