Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto_approve for hello-world #100

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Enable auto_approve for hello-world #100

merged 1 commit into from
Jun 12, 2018

Conversation

katrinleinweber
Copy link
Contributor

I am unsure whether this is necessary, because #98 has a checkbox for this, but later says We've currently made any hello-world exercises auto-approved in the backend.

Either way, shall we set other exercises to "auto_approve": true?

@jonmcalder
Copy link
Member

Thanks for following up on #98!

I interpret it as saying that auto_approve: true should be set on the first exercise if it isn't hello-world (and that hello-world will be auto-approved by default), but agree that's it's better to be explicit just in case.

I don't think we need/want to auto-approve anything else just yet though.

@jonmcalder jonmcalder merged commit 1423fcb into master Jun 12, 2018
@katrinleinweber katrinleinweber deleted the 98-autoapprove branch June 12, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants