Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move '/docs/SETUP.md' to '/SETUP.md' and '/exercises/TRACK_HINTS.md' … #34

Merged
merged 2 commits into from
Feb 27, 2017

Conversation

jonmcalder
Copy link
Member

…- this closes issue #33

@jonmcalder
Copy link
Member Author

I have split these out based on the instructions in #33 and on a cursory look at the xr/go repo which references the testing procedure in the exercises/TRACK_HINTS.md file.

We may want to review the content in each of these two files to make sure it is appropriate given where and how it will appear on the site.

So far I have just replaced "problem.R" and "test_problem.R" with "<exercise_name>.R" and "test_<exercise_name>.R" to highlight that these file names change for each problem.

@petertseng
Copy link
Member

Note that if this track (any track) has both SETUP.md and exercises/TRACK_HINTS.md, by https://github.com/exercism/trackler/blob/master/lib/trackler/implementation.rb#L105 only exercises/TRACK_HINTS.md will be used. Since the latter is meant to replace the former, it's one or the other.

@jonmcalder
Copy link
Member Author

Oh ok - I had interpreted your instructions to mean add both not one or the other. Will move everything into exercises/TRACK_HINTS.md then.

Thanks!

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I recommend that those who have the permission to merge in this repo do so, for the sake of the students completing exercises from this track -- unless there are other problems I didn't see, of course.

@jonboiser jonboiser merged commit edb7825 into exercism:master Feb 27, 2017
@jonmcalder jonmcalder mentioned this pull request Mar 31, 2017
16 tasks
jonmcalder added a commit that referenced this pull request Apr 5, 2017
Borrowed extensively from the xhaskell repo to update the README and bring it in line with other updates. Along with #34 and #40, this closes #1 and closes #24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants