Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added exercise #39

Merged
merged 12 commits into from
Mar 31, 2017
Merged

Added exercise #39

merged 12 commits into from
Mar 31, 2017

Conversation

llenk
Copy link
Contributor

@llenk llenk commented Mar 30, 2017

Added prime factors exercise

jonmcalder
jonmcalder reviewed Mar 30, 2017
View reviewed changes
Copy link
Member

@jonmcalder jonmcalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. config.json is invalid due to missing comma on line 92

  2. Please also add newlines at the end of files: example.R & prime_factors.R (http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline)

Thanks for the pull request!

@llenk
Copy link
Contributor Author

llenk commented Mar 30, 2017

I fixed those issues. Is there anything else I should change?

jonmcalder
jonmcalder approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@jonmcalder jonmcalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jonmcalder jonmcalder mentioned this pull request Mar 31, 2017
Closed
16 tasks
@jonmcalder jonmcalder merged commit c5df25a into exercism:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmcalder jonmcalder jonmcalder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llenk @jonmcalder