Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gigasecond] Implementation #596

Merged
merged 13 commits into from
Apr 26, 2023
Merged

[Gigasecond] Implementation #596

merged 13 commits into from
Apr 26, 2023

Conversation

habere-et-dispertire
Copy link
Contributor

No description provided.

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@habere-et-dispertire
Copy link
Contributor Author

habere-et-dispertire commented Feb 26, 2023

Ping @ErikSchierboom as I think this is valid -- prove passes all the tests locally. :D

I know @kytrinyx made some changes to the documentation since and if it doesn't gel then I'm happy to rework it.

It would be great if draft PRs could still run so we can still check them for validity.

@m-dango m-dango reopened this Feb 27, 2023
@habere-et-dispertire
Copy link
Contributor Author

habere-et-dispertire commented Feb 27, 2023

Thanks for reopening @m-dango ! :D

Is this perhaps failing because the new rakudo-star version 2023.02 is pending? ( The compile now requires a newer version of perl or perl subs enabled. )

Or does template-data.yaml need to be in the .meta folder? I think it used to be there under a different name, exercise-data.yaml, and perhaps the way I ran exercise-gen.raku as ./raku/bin/execise-gen.raku put it in a different folder?

@ErikSchierboom
Copy link
Member

Ping @ErikSchierboom as I think this is valid -- prove passes all the tests locally. :D

@m-dango and @kotp are the resident Raku maintainers, so you don't need me :)_

@m-dango
Copy link
Member

m-dango commented Feb 27, 2023

@habere-et-dispertire Yes, unfortunately there was a dependency for prove6 missing when the last version of Rakudo Star was built. I'm looking into now bumping the docker image to the new version of Rakudo Star.

@habere-et-dispertire
Copy link
Contributor Author

Great -- looks like the new docker image has arrived. Thanks @m-dango 🍡 !
How do we restart the checks here ?

@kotp
Copy link
Member

kotp commented Mar 3, 2023

Great -- looks like the new docker image has arrived. Thanks @m-dango dango ! How do we restart the checks here ?

I restarted the checks.

@m-dango
Copy link
Member

m-dango commented Mar 9, 2023

I don't know too much about MacOS but it seems an older version of Rakudo Star is being installed than what the latest available is? (2022.12 instead of 2023.02).

@habere-et-dispertire
Copy link
Contributor Author

I'd like to help. Let me know if I can look into anything. 👍
FWIW, after compiling and installing Rakudo Star on my macOS system, prove6 seems okay:

$ prove6 --version

prove6 0.0.12 with TAP::Harness 0.3.5 on rakudo (2023.02)

@habere-et-dispertire
Copy link
Contributor Author

Any update ?
Thanks everyone !
:D

@m-dango m-dango self-requested a review March 23, 2023 15:04
@m-dango
Copy link
Member

m-dango commented Mar 27, 2023

Workflows failing due to reasons unrelated to these changes. One of them is addressed here: #600

@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review March 27, 2023 07:05
@habere-et-dispertire
Copy link
Contributor Author

Does 2023-04 (just out) perhaps address the remaining issues ? prove6 appears still available, at least on macOS:

~/rakudo/bin $ prove6 --version
prove6 0.0.12 with TAP::Harness 0.3.5 on rakudo (2023.04)

@m-dango m-dango merged commit ce4db20 into exercism:main Apr 26, 2023
@habere-et-dispertire
Copy link
Contributor Author

Thanks ❣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants