-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug on sample dataset for Ruby problem: hamming #32
Comments
Related to #31 ? |
This is likely because you already have installed minitest as a gem on your system. If you didn't have it, then adding "gem minitest" would require that you install it, and I'd rather avoid forcing people to install dependencies. I tend to add "gem 'minitest'" manually myself (as well as "require 'minitest/pride'"). @kerrizor is right, the hamming test suite is incorrect at the moment. It's a known issue, and the correct test would probably raise an ArgumentError. |
The timing is right for this, as we are working on the hamming exercise. Work through a solution and/or close? |
The hamming part of this has been fixed (it now raises an error). The larger question applies to all of the problems: should we explicitly require that Minitest be installed as a gem? Is it still shipped as part of Ruby, and if so, what version? I think it's worth working through this. I'm leaning towards explicitly adding |
This could be managed by using 'Bundler |
If you don't have bundler, then this would be |
Do we have a script that runs when you first install the exercism gem? (In other words, it could be a dependency of the gem.) A rake test task that looks at your current working directory, and tuns the required test. The infrastructure is already here, I think. |
There's no exercism gem--just the binary which has no other dependencies. A rake task would be nice, but I don't think the infrastructure is in place, unless I'm thinking about this all wrong. |
Strange. As I have this gem installed:
Investigating it now. |
Yeah... and the dependencies include both minitest and bundler...
Right now, restricted to development. The application dependencies are thus: spec.add_dependency "json"
spec.add_dependency "faraday", ">= 0.8.8"
spec.add_dependency "thor"
spec.add_dependency "launchy", "~> 2.3.0" |
Exercism gem has been deprecated... :) never mind. |
This should be closed if all there is to do is notify folks to install the gem. The instruction is in the hello/-world/GETTING_STARTED.md file to do the And this does leave the 'set up an automated testing workflow' environment as a learning exercise for individual study as needed. |
You mentioned about explicitly requiring a minimum version of Minitest? I think the new name for Minitest::Test does this automatically/naturally, to the extent that the syntax doesn't exist in an older version. |
Yeah, if people are using a version of Rails that requires minitest 4.x, then it becomes pretty complicated to get this to run without warnings. I think adding |
Your comment has me shaving yaks this afternoon and evening. Still investigating implications. I use Bundler, so trying to simulate what people do who use neither a version manager of some kind, to include Bundler. |
I hope those yaks didn't ruin your day! |
Closing this issue as this is a "Two part" thing and the second part really has nothing to do with the hamming problem. Creating a new issue to track "explicitly require that Minitest be installed as a gem". |
clock.json: test data for clock
I hope this is the right forum to submit bug reports on the sample dataset
First off, I am getting a warning:
Warning message was suppressed by adding
gem "minitest"
to myhamming_test.rb
Second,
I believe this test has an incorrect assertion:
Correct me if I'm wrong, but assertion should be equal to zero:
The text was updated successfully, but these errors were encountered: