Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for time not date objects #78

Merged
merged 1 commit into from
Jan 26, 2015
Merged

Looking for time not date objects #78

merged 1 commit into from
Jan 26, 2015

Conversation

kotp
Copy link
Member

@kotp kotp commented Jan 25, 2015

Now shows the 46 hours and 40 seconds, rather than a date.

Re: #77

@kytrinyx
Copy link
Member

I'm curious - does it show the same offset if you use Time.utc as with Time.new?

@kotp
Copy link
Member Author

kotp commented Jan 25, 2015

  1) Failure:
GigasecondTest#test_1 [gigasecond_test.rb:10]:
Expected: 2043-01-01 00:46:40 UTC
  Actual: 2043-01-01 00:46:40 -0500

When I use UTC it overrides the local time for the system it is running on.

@kytrinyx
Copy link
Member

Right, then the solution would have to use UTC as well. That might avoid some timezone confusion, actually.

@kotp
Copy link
Member Author

kotp commented Jan 25, 2015

No, when I use utc for both the gs expectation and then use utc in the assertion, I still get the offset.

Looking into it, but I think that is due to the example solution... investigation.

@kotp
Copy link
Member Author

kotp commented Jan 25, 2015

It shouldn't be, the time given is the time given.

@kotp
Copy link
Member Author

kotp commented Jan 25, 2015

Leaving the utc out should leave the solution passing... so the request as it is should deal with the local run and pass.

@kytrinyx
Copy link
Member

Cool, thanks for digging into this!

kytrinyx added a commit that referenced this pull request Jan 26, 2015
Looking for time not date objects
@kytrinyx kytrinyx merged commit cda6a2d into exercism:master Jan 26, 2015
kytrinyx added a commit that referenced this pull request Mar 31, 2015
Looking for time not date objects
gchan pushed a commit to gchan/xruby that referenced this pull request Oct 18, 2016
Add "counter", a write-the-test-suite exercise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants