internal tooling improvements #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```sh rg --files-with-matches '#!/bin/sh' | xargs sd -s '#!/bin/sh' '#!/usr/bin/env bash' ```
ghost
commented
Feb 19, 2021
|
Some files appear unused:
I searched a local checkout with |
coriolinus
reviewed
Feb 19, 2021
coriolinus
reviewed
Feb 19, 2021
This was referenced Feb 19, 2021
Needed the same patch as in #1134.
We needed to swallow the error from grep when it did not find matches. That is what we want!
ghost
requested a review
from
|
This is ready to review :). |
coriolinus
approved these changes
Feb 23, 2021
- simplify jq pipeline - preserve globs Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
```sh
set -x
find . -name '*.sh' ! -type d -exec bash -c 'expand -t 2 "$0" > /tmp/e && mv /tmp/e "$0"' {} \;
```
Courtesy of
[SO](https://stackoverflow.com/questions/11094383/how-can-i-convert-tabs-to-spaces-in-every-file-of-a-directory)
```sh fd '.*\.sh$' | xargs chmod +x $0 ```
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was mistaken about exercism/github-actions exposing a shellcheck action. I just copied their workflow configuration into our single
tests.yml.Closes #1110.